Aloha Glenn; At the 28.07.2010 17:21, you (doiggl@xxxxxxxxxxxxxxxxxx) wrote:
The following items are still unaddressed: 1. running igrab() in the writepage() path is really going to hammer inode_lock. Something else will need to be done here. 2. Running iput() in entd() is a bit surprising. iirc there are variousways in which this can recur into the filesystem, perform I/O, etc. I guess it works.. But again, it will hammer inode_lock. 3. the writeout logic in entd_flush() is interesting (as in "holy cow"). It's very central and really needs some good comments describingwhat'sgoing on in there - what problems are being solved, which decisionsweretaken and why, etc. 4. reiser4_wait_page_writeback() needs commenting. 5. reading the comment in txnmgr.c regarding MAP_SHARED pages: a numberofthings have changed since then. We have page-becoming-writeable notifications and probably soon we'll always take a pagefault when a MAP_SHARED page transitions from pte-clean to pte-dirty (although I wouldn't recommend that a filesystem rely upon the latter for a while yet). Feel free to address them. Thanks, Edward.Has the number of items reduced at all ? just curious Cheers Glenn
I haven't looked at the code since several years. But as far as I have followed the development, all of the patch sets since then (April 2009) were only of cosmetical nature, or said with other words, to keep it coping with changes at different positions, like eg. VFS. And in a handful of blogs I got no additional/other informations, despite that the maintainer is working at a company in the field of another file system since the end of last year, so that he has only few time for Reiser FSs, and also that the opinions are that the project is dead.
Cheerio Christian *<:o) O>-< -(D)>-< -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
