> The following items are still unaddressed: > > 1. running igrab() in the writepage() path is really going to hammer > inode_lock. Something else will need to be done here. > > 2. Running iput() in entd() is a bit surprising. iirc there are various > ways > in which this can recur into the filesystem, perform I/O, etc. I > guess it > works.. > But again, it will hammer inode_lock. > > 3. the writeout logic in entd_flush() is interesting (as in "holy cow"). > It's very central and really needs some good comments describing what's > going on in there - what problems are being solved, which decisions were > taken and why, etc. > > 4. reiser4_wait_page_writeback() needs commenting. > > 5. reading the comment in txnmgr.c regarding MAP_SHARED pages: a number of > things have changed since then. We have page-becoming-writeable > notifications and probably soon we'll always take a pagefault when a > MAP_SHARED page transitions from pte-clean to pte-dirty (although I > wouldn't > recommend that a filesystem rely upon the latter for a while yet). > > Feel free to address them. > > Thanks, > Edward. Has the number of items reduced at all ? just curious Cheers Glenn -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
