Re: RFC: net/netfilter reorganization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 2008-10-07 07:34, Roman Zippel wrote:
>> 
>> Seems like config options without a one-line text are considered 
>> nonexistent for kconfig to begin with, so that nothing can depend or 
>> default on these.
>
>Not really. If one of these two symbols has a value different than 'n', it 
>should should also select BOTH_CTMARK. I did a quick test and I still get 
>the expected behaviour, so there is something else...
>
Nope. A patch as simple as

--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -317,7 +317,7 @@ config NETFILTER_XT_TARGET_CLASSIFY
          To compile it as a module, choose M here.  If unsure, say N.
 
 config NETFILTER_XT_TARGET_CONNMARK
-       tristate  '"CONNMARK" target support'
+       tristate
        depends on NF_CONNTRACK
        depends on NETFILTER_ADVANCED
        select NF_CONNTRACK_MARK

nukes TARGET_CONNMARK from .config - as in, there is not even a
"# TARGET_CONNMARK is unset" line.
As such I can understand why adding a "select ELSE" for TARGET_CONNMARK
won't work.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux