>> > Funny thing is, only when you try you see more problems a-coming.
>> > Like, Kconfig option names. Keep/Lose
>> > NETFILTER_XT_{MATCH,TARGET}_CONNMARK, and query users for a new one?
>>
>> Definitely yes. Kconfig is overloaded with netfilter
>> targets/matches and if matches/targets are collapsed into a single
>> file, then Kconfig options should be unified, as in your sample
>> patch.
>
> Agreed, but please keep the old options around (doing just a select
> on the new ones) for one or two releases.
Hm I just noticed a not-nice kconfig behavior.
If I have a .config with
TARGET_CTMARK=m
MATCH_CTMARK=m
# BOTH_CTMARK not listed at all
and a Kconfig file with
config TARGET_CTMARK
tristate
select BOTH_CTMARK
config MATCH_CTMARK
tristate
select BOTH_CTMARK
config BOTH_CTMARK
tristate "shiny new module"
Then oldconfig will still ask me to choose [N/m] for BOTH_CTMARK. Only
if I use
config TARGET_CTMARK
tristate "foo"
select BOTH_CTMARK
config MATCH_CTMARK
tristate "bar"
select BOTH_CTMARK
config BOTH_CTMARK
tristate "shiny new module"
i.e. add strings, it will proceed without asking me anything. Meh that's
bad. I can think of odd workarounds like
config TARGET_CTMARK
tristate "shiny new module"
config MATCH_CTMARK
select BOTH_CTMARK
config BOTH_CTMARK
select TARGET_CTMARK
but that looks a bit odd. Requesting more comments.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
