Jan Engelhardt wrote:
On Sunday 2008-10-05 12:11, Patrick McHardy wrote:
One thing I'm looking forward to is the elimination of all of
the xt_* prefixes, and in general better TAB completion
friendliness when I try to open netfilter source files under
emacs or grep things from the command line with tab completed
paths.
I'm not sure how emacs handles completion, would using different
prefixes for matches and targets help? Otherwise I guess we can
just get rid of the prefixes entirely.
Allow me to speak generally for humans.. we are lazy to type, so
usually it's just the first three or four characters (or less,
of course) we want to type before hitting TAB the first time.
By eliminating prefixes, you already start typing on the "real"
name, which means your chances that TAB completion returns just
a single file is much higher.
Thats true. Not using any prefixes requires keeping the
upper letter naming convention for targets though (which
I don't really mind).
The main problem with these renames is that it module aliases
don't work for "rmmod", which is a pretty common thing with
these modules. I guess we'd need to fix up module-init-tools
first.
When was the last time you used tab completion on .ko files?
I don't use tab-completion above file-level at all, its takes
way to long to initialize all the more fancy stuff.
I think this is sufficient:
obj-$(config_foo) += nfct_ftp.o
nfct_ftp-objs := ftp.c
That way, Mr Developer can use ft<TAB> to get ftp.c, but the
final module that we will be using with modprobe/rmmod still
has the prefix (and we should really have one!)
A lot of people are unloading modules in their firewall scripts
and that will break.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
