Hi, On Thu, Dec 08, 2011 at 06:55:11PM -0800, Neil Zhang wrote: > > > This driver only depends on USB_PXA_U2O, and that one will depends on > > > ARCH_MMP. > > > Do you mean I change the Kconfig for USB_PXA_U2O in this patch or > > > submit a new patch to change it? > > > > $SUBJECT doesn't need to depend on that, and that's what I'm asking you > > to do :-) > > > > Remove that depends on USB_PXA_U2O line from the Kconfig, but be sure > > that removing that won't break compilation on x86. > > > May I ask a question why depends on USB_PXA_U2O line should be removed > from the Kconfig. USB_PXA_U2O is our gadget driver, so I add the > dependence here. There are a few reasons: 1) it helps us catching compile errors with linux-next 2) it helps me compile-testing before applying on x86 3) there's no real reason for that ARCH dependency. The same controller could be bought from Marvell and used on another architecture. > > If you can provide patches removing ARCH dependency on mv_udc (making > > it buildable on x86 and all other archs) that would be great too :-) > > > I can prepare a patch to remove that dependency on mv_udc. > If so, is there no need to remove depends on USB_PXA_U2O line on mv_otg? Yes, for the same reasons above. What I want, at the end of the day, is to be able to compile everything on whatever architecture I choose and I want to avoid duplications such as the chipIdea controller which has, maybe, 3 driver in tree. Drivers, should also be named after the IP core they use, not the architecture, but that's another discussion. -- balbi
Attachment:
signature.asc
Description: Digital signature
