Hi Balbi, > -----Original Message----- > From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: 2011年12月7日 17:07 > To: Neil Zhang > Cc: balbi@xxxxxx; stern@xxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxx; linux- > usb@xxxxxxxxxxxxxxx; Chao Xie > Subject: Re: [PATCH 2/7 v2] USB: OTG: add Marvell usb OTG driver > support > > On Wed, Nov 30, 2011 at 09:57:12AM +0800, Neil Zhang wrote: > > This driver is for ChipIdea USB OTG controller on Marvell Socs. > > PXA920/MMP2/MMP3/MGx all have this USB OTG controller. > > > > Signed-off-by: Neil Zhang <zhangwm@xxxxxxxxxxx> > > --- > > drivers/usb/otg/Kconfig | 13 + > > drivers/usb/otg/Makefile | 1 + > > drivers/usb/otg/mv_otg.c | 961 > ++++++++++++++++++++++++++++++++++ > > drivers/usb/otg/mv_otg.h | 165 ++++++ > > include/linux/platform_data/mv_usb.h | 5 + > > 5 files changed, 1145 insertions(+), 0 deletions(-) create mode > > 100644 drivers/usb/otg/mv_otg.c create mode 100644 > > drivers/usb/otg/mv_otg.h > > > > diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig index > > c66481a..428018b 100644 > > --- a/drivers/usb/otg/Kconfig > > +++ b/drivers/usb/otg/Kconfig > > @@ -130,4 +130,17 @@ config FSL_USB2_OTG > > help > > Enable this to support Freescale USB OTG transceiver. > > > > +config USB_PXA_U2O_OTG > > + tristate "Marvell PXA9xx USB OTG support" > > + depends on USB_PXA_U2O > > drop the ARCH dependency. Make this compilable on all archs. Can't take > it as is, sorry. NAK. > Do you mean the following two head file? #include <mach/hardware.h> #include <asm/mach-types.h> If so, I can remove them. BTW: Do I have to submit a new version for all this set of patches or only update this one? Thanks. > And before you reply saying that driver XYZ doesn't compile on all > arches, I'm starting to enforce that for new drivers, converting the > older ones is a bit more difficult. > > -- > balbi Best Regards, Neil Zhang ?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
