Re: [PATCH 2/7 v2] USB: OTG: add Marvell usb OTG driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Dec 07, 2011 at 02:35:56AM -0800, Neil Zhang wrote:
> > > diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig index
> > > c66481a..428018b 100644
> > > --- a/drivers/usb/otg/Kconfig
> > > +++ b/drivers/usb/otg/Kconfig
> > > @@ -130,4 +130,17 @@ config FSL_USB2_OTG
> > >  	help
> > >  	  Enable this to support Freescale USB OTG transceiver.
> > >
> > > +config USB_PXA_U2O_OTG
> > > +	tristate "Marvell PXA9xx USB OTG support"
> > > +	depends on USB_PXA_U2O
> > 
> > drop the ARCH dependency. Make this compilable on all archs. Can't take
> > it as is, sorry. NAK.
> > 
> 
> Do you mean the following two head file?
> #include <mach/hardware.h>
> #include <asm/mach-types.h>
> 
> If so, I can remove them.

Yes. Also drop the dependency from Kconfig. And make sure this driver
compiles fine with allmodconfig and allyesconfig on x86.

> BTW: Do I have to submit a new version for all this set of patches or
> only update this one?  Thanks.

only this one :-) EHCI is for Alan and the gadget ones I have already
applied. As a tip, next time, please split your series too. Mixing
different stuff into one series makes it also difficult for different
maintainers to pick the correct patches :-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux