> -----Original Message----- > From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: 2011年12月7日 18:41 > To: Neil Zhang > Cc: balbi@xxxxxx; stern@xxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxx; linux- > usb@xxxxxxxxxxxxxxx; Chao Xie > Subject: Re: [PATCH 2/7 v2] USB: OTG: add Marvell usb OTG driver > support > > Hi, > > On Wed, Dec 07, 2011 at 02:35:56AM -0800, Neil Zhang wrote: > > > > diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig > > > > index c66481a..428018b 100644 > > > > --- a/drivers/usb/otg/Kconfig > > > > +++ b/drivers/usb/otg/Kconfig > > > > @@ -130,4 +130,17 @@ config FSL_USB2_OTG > > > > help > > > > Enable this to support Freescale USB OTG transceiver. > > > > > > > > +config USB_PXA_U2O_OTG > > > > + tristate "Marvell PXA9xx USB OTG support" > > > > + depends on USB_PXA_U2O > > > > > > drop the ARCH dependency. Make this compilable on all archs. Can't > > > take it as is, sorry. NAK. > > > > > > > Do you mean the following two head file? > > #include <mach/hardware.h> > > #include <asm/mach-types.h> > > > > If so, I can remove them. > > Yes. Also drop the dependency from Kconfig. And make sure this driver > compiles fine with allmodconfig and allyesconfig on x86. > This driver only depends on USB_PXA_U2O, and that one will depends on ARCH_MMP. Do you mean I change the Kconfig for USB_PXA_U2O in this patch or submit a new patch to change it? > > BTW: Do I have to submit a new version for all this set of patches or > > only update this one? Thanks. > > only this one :-) EHCI is for Alan and the gadget ones I have already > applied. As a tip, next time, please split your series too. Mixing > different stuff into one series makes it also difficult for different > maintainers to pick the correct patches :-) Thanks for your kindly recommends. > > -- > balbi Best Regards, Neil Zhang ?韬{.n?????%??檩??w?{.n???{炳???骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
