Re: [PATCH 2/7 v2] USB: OTG: add Marvell usb OTG driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 30, 2011 at 09:57:12AM +0800, Neil Zhang wrote:
> This driver is for ChipIdea USB OTG controller on Marvell Socs.
> PXA920/MMP2/MMP3/MGx all have this USB OTG controller.
> 
> Signed-off-by: Neil Zhang <zhangwm@xxxxxxxxxxx>
> ---
>  drivers/usb/otg/Kconfig              |   13 +
>  drivers/usb/otg/Makefile             |    1 +
>  drivers/usb/otg/mv_otg.c             |  961 ++++++++++++++++++++++++++++++++++
>  drivers/usb/otg/mv_otg.h             |  165 ++++++
>  include/linux/platform_data/mv_usb.h |    5 +
>  5 files changed, 1145 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/otg/mv_otg.c
>  create mode 100644 drivers/usb/otg/mv_otg.h
> 
> diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig
> index c66481a..428018b 100644
> --- a/drivers/usb/otg/Kconfig
> +++ b/drivers/usb/otg/Kconfig
> @@ -130,4 +130,17 @@ config FSL_USB2_OTG
>  	help
>  	  Enable this to support Freescale USB OTG transceiver.
>  
> +config USB_PXA_U2O_OTG
> +	tristate "Marvell PXA9xx USB OTG support"
> +	depends on USB_PXA_U2O

drop the ARCH dependency. Make this compilable on all archs. Can't take
it as is, sorry. NAK.

And before you reply saying that driver XYZ doesn't compile on all
arches, I'm starting to enforce that for new drivers, converting the
older ones is a bit more difficult.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux