Hi Balbi, > -----Original Message----- > From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: 2011年12月7日 21:53 > To: Neil Zhang > Cc: balbi@xxxxxx; stern@xxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxx; linux- > usb@xxxxxxxxxxxxxxx; Chao Xie > Subject: Re: [PATCH 2/7 v2] USB: OTG: add Marvell usb OTG driver > support > > Hi, > > On Wed, Dec 07, 2011 at 03:53:44AM -0800, Neil Zhang wrote: > > > -----Original Message----- > > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > > Sent: 2011年12月7日 18:41 > > > To: Neil Zhang > > > Cc: balbi@xxxxxx; stern@xxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxx; linux- > > > usb@xxxxxxxxxxxxxxx; Chao Xie > > > Subject: Re: [PATCH 2/7 v2] USB: OTG: add Marvell usb OTG driver > > > support > > > > > > Hi, > > > > > > On Wed, Dec 07, 2011 at 02:35:56AM -0800, Neil Zhang wrote: > > > > > > diff --git a/drivers/usb/otg/Kconfig > b/drivers/usb/otg/Kconfig > > > > > > index c66481a..428018b 100644 > > > > > > --- a/drivers/usb/otg/Kconfig > > > > > > +++ b/drivers/usb/otg/Kconfig > > > > > > @@ -130,4 +130,17 @@ config FSL_USB2_OTG > > > > > > help > > > > > > Enable this to support Freescale USB OTG transceiver. > > > > > > > > > > > > +config USB_PXA_U2O_OTG > > > > > > + tristate "Marvell PXA9xx USB OTG support" > > > > > > + depends on USB_PXA_U2O > > > > > > > > > > drop the ARCH dependency. Make this compilable on all archs. > > > > > Can't take it as is, sorry. NAK. > > > > > > > > > > > > > Do you mean the following two head file? > > > > #include <mach/hardware.h> > > > > #include <asm/mach-types.h> > > > > > > > > If so, I can remove them. > > > > > > Yes. Also drop the dependency from Kconfig. And make sure this > > > driver compiles fine with allmodconfig and allyesconfig on x86. > > > > > > > This driver only depends on USB_PXA_U2O, and that one will depends on > > ARCH_MMP. > > Do you mean I change the Kconfig for USB_PXA_U2O in this patch or > > submit a new patch to change it? > > $SUBJECT doesn't need to depend on that, and that's what I'm asking you > to do :-) > > Remove that depends on USB_PXA_U2O line from the Kconfig, but be sure > that removing that won't break compilation on x86. > May I ask a question why depends on USB_PXA_U2O line should be removed from the Kconfig. USB_PXA_U2O is our gadget driver, so I add the dependence here. > If you can provide patches removing ARCH dependency on mv_udc (making > it buildable on x86 and all other archs) that would be great too :-) > I can prepare a patch to remove that dependency on mv_udc. If so, is there no need to remove depends on USB_PXA_U2O line on mv_otg? Thanks. > -- > balbi Best Regards, Neil Zhang ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
