On Wed, Oct 14, 2009 at 10:30 AM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> wrote: > Devin, > > You can't simply remove the DVB gpio setup there. It is used when you change > from analog/digital, when you restore from hibernation and to turn on the demod > on hybrid devices, and to turn it off after stopping DVB. If you're having troubles > there, then probably the DVB demod poweron/reset gpio sequence is wrong or > incomplete. The em28xx_dvb_bus_ctrl() callback should already be putting it into digital mode when the frontend gets opened. The point behind the change is that we should not be switching in and out of dvb mode whenever somebody starts/stops streaming. It should be controlled based on opening closing the frontend (which is what the ts_bus_ctrl callback should accomplish). We ran into the issue because the dvb gpio for the board in question actually strobes the reset rather than just taking it out of reset. While I could change the dvb_gpio to match some of the other boards, we really *should* be strobing the reset after powering up the chip. If we're really relying on the calls in the start_feed() callback when coming out of hibernation, then the code is broken in that case as well, since there is no guarantee the demod is properly re-initialized. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
