On Tue, Dec 17, 2024 at 02:28:09PM +0100, Vít Ondruch wrote:
>
> Dne 16. 12. 24 v 23:13 Miroslav Suchý napsal(a):
> >Dne 16. 12. 24 v 7:03 odp. Miro Hrončok napsal(a):
> >>
> >>And based on my experience, I doubt this particular
> >>provenpackager status was stripped based on something like that.
> >>
> >>Sure, I guess we all agree that the line is fuzzy and probably
> >>not very well documented/defined. That does not mean we use that
> >>to justify problematic provenpackager behavior.
> >
> >I agree with Miro.
> >
> >I doubt anyone complains about release-bumps.
> >
> >In past, I complained about other PP commits (not probinson) -
> >they changed somehow random parts of spec. E.g. URL in SOURCEX. Or
> >/usr/bin to %{_bindir}. This changes were either problematic for
> >my workflow or simply incorrect. And these changes (directly done
> >in dist-git) were not triggered by any issue. Though, I was alway
> >able to resolve it with the author without the need to reach
> >FESCO.
> >
>
> This is not recent example, but really bad example of PP's work IMHO:
>
> https://src.fedoraproject.org/rpms/ruby/c/c31c7edb6913eb7417ee68c59997548df2943dde
>From 2014, when the pull-request workflow didn't exist. I'm not sure
what the alternative was back then. Send a specfile patch to the
maintainer by email? Discuss it on IRC? (We don't actually know
whether or not those things occurred.)
I suspect given the year and the context, Peter was probably doing
this to add Arm support.
Anyway about the content of the change, rather than the communication:
- The use of wildcards in .gitignore is a large change, but also an
improvement.
- Renumbering the patch lines is invasive perhaps, but the result is
cleaner. I probably wouldn't have done this to someone else's
spec.
- A new patch was added with a clear reference to upstream status.
- Forcing the Tcl/Tk version needs an explanation.
It would be nice if these had been done as separate commits, but again
this was back in 2014 when things were looser.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
