On Wednesday, 18 December 2024 at 20:15, Richard W.M. Jones wrote: > On Tue, Dec 17, 2024 at 02:28:09PM +0100, Vít Ondruch wrote: [...] > > This is not recent example, but really bad example of PP's work IMHO: > > > > https://src.fedoraproject.org/rpms/ruby/c/c31c7edb6913eb7417ee68c59997548df2943dde > > From 2014, when the pull-request workflow didn't exist. I'm not sure > what the alternative was back then. Send a specfile patch to the > maintainer by email? Discuss it on IRC? I remember getting patches via bugzilla attachments and doing the same myself at times. [...] > Anyway about the content of the change, rather than the communication: > > - The use of wildcards in .gitignore is a large change, but also an > improvement. > > - Renumbering the patch lines is invasive perhaps, but the result is > cleaner. I probably wouldn't have done this to someone else's > spec. > > - A new patch was added with a clear reference to upstream status. > > - Forcing the Tcl/Tk version needs an explanation. > > It would be nice if these had been done as separate commits, but again > this was back in 2014 when things were looser. Agreed. Still, not something I'd get upset enough to bring it to FESCo and ask for the offender's PP privileges to be revoked. Regards, Dominik -- Fedora https://fedoraproject.org Deep in the human unconscious is a pervasive need for a logical universe that makes sense. But the real universe is always one step beyond logic. -- from "The Sayings of Muad'Dib" by the Princess Irulan -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
