On Tue, Dec 17, 2024, 14:37 Peter Robinson <pbrobinson@xxxxxxxxx> wrote:
On Tue, 17 Dec 2024 at 13:28, Vít Ondruch <vondruch@xxxxxxxxxx> wrote:
This is not recent example, but really bad example of PP's work IMHO:
https://src.fedoraproject.org/rpms/ruby/c/c31c7edb6913eb7417ee68c59997548df2943ddeThat was from 10 years ago, likely when I was one of the two rel-eng people dealing with composes, and it was likely blocking the building of release artifacts (it was so long ago I don't remember), I also don't believe we even had pagure at that time and hence no PRs, I don't think it's relevant or useful in this discussion, a lot of things have changed in the project over that time, and like adamw has said as part of release building processes things are done to get things done and working.
I think what Vit is saying is that this change included unrelated cleanups, such as changing .gitignore and renumbering patches that was complete orthogonal to the actual fix. It's not the releng work and getting the fix out quickly that's the issue, it's the unrelated cleanups that should not have been part of the change and should have been discussed with the package maintainer first instead. Furthermore, it is often cleanest to split these things up into multiple commits, and add some motivation for changes - especially when it is another person's package and they might want to read up what and why was changed.
Note that I would have been perfectly happy to receive a commit like this to one of my packages even though I would myself do it differently.
I suspect that unrelated cleanups that bring packaging preferences into play are what led to the conflict you had with the rust sig lead as well.
(Once again I find fesco's decision questionable and do not agree with it. I am only writing this email to try to clarify what people might find at fault seeing this changeset.)
--
Kalev
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
