* Daniel P. Berrangé: > On Fri, Nov 29, 2024 at 03:48:02PM +0000, Richard W.M. Jones wrote: >> On Fri, Nov 29, 2024 at 04:36:14PM +0100, Florian Weimer wrote: >> > * Daniel P. Berrangé: >> > >> > > I think I'd prefer to stay away from redhat-rpm-config. Not because it >> > > is a problem in Fedora, but because it will cause us pain downstream >> > > to deal with RHEL development process bureaucracy to commit changes >> > > into a package we don't directly own as virt maintainers. >> > >> > How do you plan to install the new package into the buildroot, so that >> > it's there when the SRPM is generated? >> > >> > (Maybe dynamic build dependencies can be used to solve this without >> > buildroot preseeding, but seems a bit convoluted.) >> >> For better or worse redhat-rpm-config has Requires on a whole bunch of >> these *-srpm-macros packages: >> >> https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/redhat-rpm-config.spec#_94 >> >> AIUI that is how the buildroot gets populated. > > Isn't this only needed for historical compat ? I was anticipating that > apps would directly "BuildRequires: qemu-srpm-macros", *not* get it > indirectly via redhat-rpm-config But that's not installed when the SRPM is built, so you can't use macros defined in qemu-srpm-macros. Looking at <https://fedoraproject.org/wiki/Changes/DynamicBuildRequires>, I think you would have to add: %generate_buildrequires echo qemu-srpm-macros And then make the use of qemu_arches macro conditional so that parsing does not fail while qemu-srpm-macros is not installed. I'm not sure if this is the intended use case for %generate_buildrequires. Thanks, Florian -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
