On Fri, Nov 29, 2024 at 04:16:51PM +0000, Richard W.M. Jones wrote: > On Fri, Nov 29, 2024 at 04:02:43PM +0000, Daniel P. Berrangé wrote: > > On Fri, Nov 29, 2024 at 03:48:02PM +0000, Richard W.M. Jones wrote: > > > On Fri, Nov 29, 2024 at 04:36:14PM +0100, Florian Weimer wrote: > > > > * Daniel P. Berrangé: > > > > > > > > > I think I'd prefer to stay away from redhat-rpm-config. Not because it > > > > > is a problem in Fedora, but because it will cause us pain downstream > > > > > to deal with RHEL development process bureaucracy to commit changes > > > > > into a package we don't directly own as virt maintainers. > > > > > > > > How do you plan to install the new package into the buildroot, so that > > > > it's there when the SRPM is generated? > > > > > > > > (Maybe dynamic build dependencies can be used to solve this without > > > > buildroot preseeding, but seems a bit convoluted.) > > > > > > For better or worse redhat-rpm-config has Requires on a whole bunch of > > > these *-srpm-macros packages: > > > > > > https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/redhat-rpm-config.spec#_94 > > > > > > AIUI that is how the buildroot gets populated. > > > > Isn't this only needed for historical compat ? I was anticipating that > > apps would directly "BuildRequires: qemu-srpm-macros", *not* get it > > indirectly via redhat-rpm-config > > I think there's an ordering problem, for example, you can't expand any > qemu macros until qemu-srpm-macros is installed, but using > BuildRequires includes it too late. IIRC anyway. Oh, I see, so the ordering problem is something that affects '-srpm-macros' packages but not '-rpm-macros' packages. So if it is something that affects parseability of a spec file it would be in -srpm-macros, but if expanding it only matters at build time, then -rpm-macros is sufficient ? With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
