On Fri, Nov 29, 2024 at 03:36:44PM +0100, Miro Hrončok wrote: > On 28. 11. 24 23:49, Neal Gompa wrote: > > On Thu, Nov 28, 2024 at 4:30 AM Florian Weimer <fweimer@xxxxxxxxxx> wrote: > > > > > > * Richard W. M. Jones: > > > > > > > One question is whether it's better to add this as a sub-package of > > > > qemu, or as a new source package. Using a new source package means we > > > > won't be introducing awkward circular build dependencies, or a > > > > heavyweight build dependency on qemu for non-virt packages. The price > > > > is the overhead of having another source package. It would also be bureaucratically simpler to just make it a sub-RPM of 'qemu' rather than a standalone qemu-srpm-macros package, but given the frequency of changes that's not a massive pain, given that virt maintainers would still own it. > > > > > > Given that this going to change quite rarely, you could stick it > > > directly into redhat-rpm-config as well, similar to what we have today > > > with /usr/lib/rpm/macros.d/macros.valgrind-srpm. > > > > > > > Please don't. I don't want it there. It makes things complicated when > > redhat-rpm-config gets changed/backported incompatibly in RHEL. > > In what way? We have other such macros there. I'd not expect this to be > problematic and your answers surprised me. I think I'd prefer to stay away from redhat-rpm-config. Not because it is a problem in Fedora, but because it will cause us pain downstream to deal with RHEL development process bureaucracy to commit changes into a package we don't directly own as virt maintainers. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
