On 20 Jan 2018 20:31, Rüdiger Meier wrote: > On 01/20/2018 07:14 PM, Mike Frysinger wrote: > > On 20 Jan 2018 18:50, Rüdiger Meier wrote: > >> On 01/19/2018 07:21 PM, Mike Frysinger wrote: > >>> On 19 Jan 2018 10:40, Karel Zak wrote: > >>>> On Thu, Jan 18, 2018 at 09:47:17PM -0500, Mike Frysinger wrote: > >>>>> why don't we just support ncurses's pkg-config files as the default ? > >>>>> $ pkg-config --cflags ncurses > >>>>> -D_GNU_SOURCE > >>>>> $ pkg-config --cflags ncursesw > >>>>> -D_GNU_SOURCE -I/usr/include/ncursesw > >>>> > >>>> because pkg-config is not supported by ncurses upstream by default and > >>>> it's not always the best solution. > >>> > >>> you mean upstream's configure script doesn't default it to on. distros > >>> can (and many do) simply pass --enable-pc-files to get them. but i don't > >>> see how that's relevant to preference when it comes to detection. > >>> > >>>> See commit 4c12a334dc4104d16dc06edf51904b08b08fcdfa. > >>> > >>> seems like that's trivial to resolve with a compile test rather than > >>> throwing it all out. xxx-config scripts provide bad defaults when you > >>> cross-compile because now the user has to make sure the build's copy > >>> of ncurses-config don't get used. > >>> > >>>> The ncurses detection and variability in distros is horrible. We > >>>> already tried all possible combinations and always someone complains > >>>> about the way how we detect ncurses. See mailing list archive for more > >>>> information. > >>> > >>> that's the point of pkg-config. if someone is having problems because > >>> they're doing something weird/non-standard, tell them to sort out their > >>> pkg-config installs. > >> > >> non-standard is to have ncurses.pc installed. > > > > that's a silly position to try to take. you're claiming anything that isn't > > turned on by default in `./configure` is non-standard ? > > No, as you could have read I'm talking only about --enable-pc-files being non > standard. Many distros and users are not using it most distros are enabling it. Debian & Fedora & openSUSE & Gentoo & ArchLinux & OpenEmbedded OE and everything based on it are enabling them. so it's the common case now, and if that's what it requires for you define something "standard", then it is standard now. > and you can't just call them all stupid. i didn't call anyone stupid. don't put words in my mouth. > We have to support this case first. i didn't say to drop xxx-config usage. i said it shouldn't come first. -mike
Attachment:
signature.asc
Description: Digital signature
