On 19 Jan 2018 10:40, Karel Zak wrote: > On Thu, Jan 18, 2018 at 09:47:17PM -0500, Mike Frysinger wrote: > > On 01 Aug 2017 09:20, Karel Zak wrote: > > > On Mon, Jul 31, 2017 at 09:46:39PM -0300, Carlos Santos wrote: > > > > > From: "Carlos Santos" <casantos@xxxxxxxxxxxxxx> > > > > > To: util-linux@xxxxxxxxxxxxxxx > > > > > Sent: Monday, July 31, 2017 9:12:03 PM > > > > > Subject: Problem building util-linux without a separate ncursesw include dir > > > > > > > > > of util-linux. Would it be possible to make the location of ncursesw > > > > > headers configurable, instead? > > > > > > We test for alone ncurses.h and term.h in the for non-wide ncurses. > > > Can you send output from your configure from the current master > > > branch (or v2.30.1)? > > > > > > > I was thinking on something simple, like https://pastebin.com/VqM9G9yu > > > > > > Hmm, but you don't distinguish between wide and non-wide ncurses. > > > > why don't we just support ncurses's pkg-config files as the default ? > > $ pkg-config --cflags ncurses > > -D_GNU_SOURCE > > $ pkg-config --cflags ncursesw > > -D_GNU_SOURCE -I/usr/include/ncursesw > > because pkg-config is not supported by ncurses upstream by default and > it's not always the best solution. you mean upstream's configure script doesn't default it to on. distros can (and many do) simply pass --enable-pc-files to get them. but i don't see how that's relevant to preference when it comes to detection. > See commit 4c12a334dc4104d16dc06edf51904b08b08fcdfa. seems like that's trivial to resolve with a compile test rather than throwing it all out. xxx-config scripts provide bad defaults when you cross-compile because now the user has to make sure the build's copy of ncurses-config don't get used. > The ncurses detection and variability in distros is horrible. We > already tried all possible combinations and always someone complains > about the way how we detect ncurses. See mailing list archive for more > information. that's the point of pkg-config. if someone is having problems because they're doing something weird/non-standard, tell them to sort out their pkg-config installs. that's a lot easier than trying to cater to all the stupid ways people try to set up their build environments. -mike
Attachment:
signature.asc
Description: Digital signature
