On 20 Jan 2018 18:50, Rüdiger Meier wrote: > On 01/19/2018 07:21 PM, Mike Frysinger wrote: > > On 19 Jan 2018 10:40, Karel Zak wrote: > >> On Thu, Jan 18, 2018 at 09:47:17PM -0500, Mike Frysinger wrote: > >>> On 01 Aug 2017 09:20, Karel Zak wrote: > >>>> On Mon, Jul 31, 2017 at 09:46:39PM -0300, Carlos Santos wrote: > >>>>>> From: "Carlos Santos" <casantos@xxxxxxxxxxxxxx> > >>>>>> To: util-linux@xxxxxxxxxxxxxxx > >>>>>> Sent: Monday, July 31, 2017 9:12:03 PM > >>>>>> Subject: Problem building util-linux without a separate ncursesw include dir > >>>>> > >>>>>> of util-linux. Would it be possible to make the location of ncursesw4c12a334dc4104d16dc06edf51904b08b08fcdfa > >>>>>> headers configurable, instead? > >>>> > >>>> We test for alone ncurses.h and term.h in the for non-wide ncurses. > >>>> Can you send output from your configure from the current master > >>>> branch (or v2.30.1)? > >>>> > >>>>> I was thinking on something simple, like https://pastebin.com/VqM9G9yu > >>>> > >>>> Hmm, but you don't distinguish between wide and non-wide ncurses. > >>> > >>> why don't we just support ncurses's pkg-config files as the default ? > >>> $ pkg-config --cflags ncurses > >>> -D_GNU_SOURCE > >>> $ pkg-config --cflags ncursesw > >>> -D_GNU_SOURCE -I/usr/include/ncursesw > >> > >> because pkg-config is not supported by ncurses upstream by default and > >> it's not always the best solution. > > > > you mean upstream's configure script doesn't default it to on. distros > > can (and many do) simply pass --enable-pc-files to get them. but i don't > > see how that's relevant to preference when it comes to detection. > > > >> See commit 4c12a334dc4104d16dc06edf51904b08b08fcdfa. > > > > seems like that's trivial to resolve with a compile test rather than > > throwing it all out. xxx-config scripts provide bad defaults when you > > cross-compile because now the user has to make sure the build's copy > > of ncurses-config don't get used. > > > >> The ncurses detection and variability in distros is horrible. We > >> already tried all possible combinations and always someone complains > >> about the way how we detect ncurses. See mailing list archive for more > >> information. > > > > that's the point of pkg-config. if someone is having problems because > > they're doing something weird/non-standard, tell them to sort out their > > pkg-config installs. > > non-standard is to have ncurses.pc installed. that's a silly position to try to take. you're claiming anything that isn't turned on by default in `./configure` is non-standard ? have you ever actually tried building ncurses before and see what its defaults are ? ncursesw isn't the default, neither is installing into a subdir like /usr/include/ncursesw. neither is libtinfo nor libtinfow. > Also cross-compiling is certainly more "weird" than not cross-compiling. you are aware that multilib is cross-compiling right ? so people are doing it every day on all the mainstream distros. > Regarding "tell them", > Have you tried yet to ask ncurses upstream about installing *.pc files > by default? i can send them an e-mail, but Thomas often leans towards not changing things from how they've always been done, so i'm not exactly hopeful. > > that's a lot easier than trying to cater to all > > the stupid ways people try to set up their build environments. > > Installing ncurses via './configure && make install' is not the most > stupid thing IMO ... Maybe just remove your ncurses-config system wide > if you don't like it or use it correctly. Could be easier than telling > all other people on the planet that they have to install ncurses in a way > you like ... telling people to mess with their build system (actively breaking it), especially when they might be on a shared system or where they don't have admin access, doesn't sound like a great idea to me. especially when it's trivial for them to resolve with --enable-pc-files. then again, the number of people who are building & installing ncurses by hand seems significantly lower than those who get it from distros, so catering to their choices (that then break things) doesn't seem worth it when they can simply adjust to do what everyone else is doing. -mike
Attachment:
signature.asc
Description: Digital signature
