On 01/08/2018 05:55 AM, Karel Zak wrote: > On Sat, Jan 06, 2018 at 11:11:31AM -0500, J William Piggott wrote: >> What I dislike the most is that debugging is very seldom used, yet debugging is >> initialized unconditionally whether it is wanted or not. This is completely >> unnecessary; an option does the job just as well without the added overhead. > > It's one getenv() call, nothing else. See libc for how many env.vars > it's sensitive. For glibc it's mostly only to honor the POSIX environment as it is required to do. It also uses secure_getenv(); I see that you've since added something simular to debug.h. That is one type of security problem that I was talking about; I think there could be more. The glibc manual says: The argv mechanism is typically used to pass command-line arguments specific to the particular program being invoked. The environment, on the other hand, keeps track of information that is shared by many programs, changes infrequently, and that is less frequently used. I wonder how a debug.h patch would be received on the libc-alpha list? Anyway, I don't want to cause problems about this. You've made a compromise for hwclock and I appreciate that. My comments are only food-for-thought, or as you say brainstorming. I just think the general concept is not so good. -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
