Re: [PATCH 2/2] hwclock: add --ul-debug implementing debug.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 24, 2017 at 03:38:58PM -0500, J William Piggott wrote:
> 
> Undocumented at this time, because it is a skeleton
> implementation.  More debugging points are to be added after
> refactoring is complete, or ad hoc in the mean time.
> 
> When fully implemented, enough time may have passed that the
> deprecated --debug could be used to replace --ul-debug.

We use everywhere env.variables (e.g. HWCLOCK_DEBUG=). The macro
__UL_INIT_DEBUG() already provides all necessary functionality for
this purpose. 

It also allows to use human readable names for the masks or hex
numbers. See for example  sys-utils/lsns.c or libsmartcols/src/init.c
for more complex usage. The human readable masks are optional and now
used by shared libs only, see for example "LIBSMARTCOLS_DEBUG=help
lsns".

I'd like to keep things consistent and with no exceptions...

IMHO "hwclock --verbose" is good idea for ordinary users and
"HWCLOCK_DEBUG=all hwclock" for developers.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux