Proposed patch for new callback in sip_inv module: on_rx_reinvite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ruud,

thanks for bumping up the thread. I haven't looked at it in detail, but so
far it looks simple and straightforward indeed. Couple of things are not
clear though. So the reinvite callback will be called instead of
on_rx_offer(), which means that the application has to manage SDP
negotiation itself outside on_media_update() framework? (Note: I might be
talking rubish here).

Also what about UPDATE? :)

Cheers
 Benny

On Thu, Jan 15, 2009 at 3:57 PM, Ruud Klaver <ruud at ag-projects.com> wrote:

> Hi,
>
> A while ago I submitted a patch. I have included an updated version of this
> patch that should work against the latest SVN revision. Could you guys
> please review the impact of this patch and consider it for inclusion in the
> SVN tree? Personally I am already using this patch in our own application to
> have better control over re-INVITEs.
>
>
> Thanks in advance.
>
> Ruud Klaver
> AG Projects
>
>
>
>
> On 22 Oct 2008, at 17:39, Ruud Klaver wrote:
>
>  Hi,
>>
>> Some time ago I discussed the possibility of giving the application more
>> control over the response to the re-INVITE in the sip_inv module. Included
>> is a simple patch which adds another callback to the pjsip_inv_callback
>> struct.
>>
>> In fact, it turned out simpler than I had imagined, since we can re-use
>> the pjsip_inv_initial_answer() and pjsip_inv_answer() functions to reply to
>> the re-INVITE. I took some time to study the code in sip_inv.c and I believe
>> this should work correctly. Initial tests seem to confirm this. For more
>> details, see the added comment in the patch.
>>
>> Benny (and others), could you please review this patch for inclusion?
>> Thanks in advance.
>>
>> Ruud Klaver
>> AG Projects
>>
>> <pjsip-2355-sip_inv-on_rx_reinvite.patch>
>> _______________________________________________
>> Visit our blog: http://blog.pjsip.org
>>
>> pjsip mailing list
>> pjsip at lists.pjsip.org
>> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>>
>
>
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20090116/93cbca3e/attachment.html>


[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux