Hi Benny, On 16 Jan 2009, at 17:29, Benny Prijono wrote: > Hi Ruud, > > thanks for bumping up the thread. I haven't looked at it in detail, > but so far it looks simple and straightforward indeed. Couple of > things are not clear though. So the reinvite callback will be called > instead of on_rx_offer(), which means that the application has to > manage SDP negotiation itself outside on_media_update() framework? > (Note: I might be talking rubish here). Well, thanks for looking over the patch. Basically the code flow will be the same for responding to an initial INVITE as for a re-INVITE. What I'm doing right now is calling pjsip_inv_answer() with the SDP for the response as an argument, then pjsip_inv_send_msg(). For both cases this uses the SDP negotiation framework, and indeed after responding to a re-INVITE, the on_media_update() callback will be called with the result of the negotiation, just as for the original INVITE. > > Also what about UPDATE? :) Ah, good question. I spent some time thinking about this when making the change to the code, but in the end this functionality is not required for UPDATE, as it requires and immediate response according to the RFC. This is why, for an incoming UPDATE, on_rx_offer() is still called. Or at least that's what should happen. I haven't been able to test it, as my application doesn't deal with UDPATEs yet. > > Cheers > Benny > Ruud Klaver AG Projects
