> I'm sorry that you had to shape my code twice. Did you use some
> utility?
I did not shape it twice. Instead, I recoded the diffs in the new code.
Wasn't really complicated.
> Well, none of the two file types (pwm/fan_min) is perfekt for that
> case. It would be necessary to have something like 'pwm_min'!
If we have to choose, this is more like pwm, at least because of the
unit. What made me think wrong was the fact that it was named fan_min in
the 2.4 driver, and that code in sensors/chips.c:
&& !sensors_get_feature(*name,SENSORS_FSCHER_FAN1,&fan)
&& !sensors_get_feature(*name,SENSORS_FSCHER_FAN1_MIN,&min_rpm)
(...)
else if (fan < min_rpm)
printf("\t%6.0f RPM (not present or faulty)\n",fan);
else
printf("\t%6.0f RPM \n",fan);
I just can't make any sense out of this comparison. Units don't even
match. Am I missing something or is it plain wrong?
I read in the Hermes data sheet that FSC doesn't recommend to set the
pwm value lower than what it was set to by the BIOS. Since I don't think
anyone would want to set it higher (what would be the point? it is
supposed to go higher by itself on high load) I wonder if it is even
worth handling it in the driver. If we do, one possible safety would be
to store the registers value as the driver is loaded and not to allow
subsequent sets to set it lower than that.
Here is the plan I propose:
1* Clean up sensors code so that it doesn't reference fan_min. For one
thing, it'll let us get rid of the errors you had when running
"sensors". Or at least use the value the way it should be (doesn't seem
to be the case as of now).
2* Either rename fan_min in libsensors to pwm, or even remove it
completely. Depends if you want to keep it or not. If it is removed,
update sensors.conf accordingly.
3* If you want to keep the pwm stuff, rename it in the 2.4 driver as
well.
4* If you don't want to keep the pwm stuff, remove it from the 2.6
driver.
Usually, fan speeds are controled by scripts, not sensors. In this case
it is a bit different since the system can make fans go higher by
itself, so no closed-loop script is needed.
Basically everything is possible, keeping it in the driver only,
driver+library, driver+library+sensors.conf or
driver+library+sensors.conf+sensors. Depends on how useful the feature
is to you.
I can handle points 1 and 2, while I would let you handle points 3 and
4. Just tell me what you think should be done so that I can fix things
in the correct way.
Thanks.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
