Hi Nikolai, Sorry for the late reply. Yes, ozlabs patchwork code is refactored from synopsys version, as far as I understand. Are you referring to the parameter OTG_EN_DED_TX_FIFO in the configuration? If that's the case, the core in our platform does uses dedicated FIFO. Thanks. On Wed, Jan 25, 2012 at 8:26 PM, Nikolai Zhubr <n-a-zhubr@xxxxxxxxx> wrote: > > Hello, > 24.01.2012 20:02, Loh Tien Hock: > >> Hi Nikolai. >> >> I tried the patch with g_serial. it needed some fix I have in my >> company's repository for slave mode. Dma mode works correctly. > > > Because the code in ozlabs patchwork does not seem to have anything new or different (compared to synopsys version) with respect to the problem I'm observing, I'd guess you only tried core(s) with a so called "Dedicated FIFO Enhancement". Then it might work indeed. > > However, the driver should either refuse to work without dedicated FIFOs present and state so honestly, or actually support such configuration correctly. Otherwise, it is still broken. > > Personally, I'd prefer this configuration supported rather then refused, of course. > > Thank you. > Nikolai > > >> >> g_ether initializes correctly in kernel 3.0. There's a fix in g_ether >> that doesn't exist in kernel 2.6. I haven't tested the functionality >> of g_ether though. >> >> I'll be discussing with my colleague whether to rewrite or refactor the code. >> >> Thanks. >> >> On Tue, Jan 24, 2012 at 9:35 PM, Nikolai Zhubr<n-a-zhubr@xxxxxxxxx> wrote: >>> >>> >>> Hello Tien, >>> >>> 24.01.2012 6:54, thloh85: >>> [trim] >>> >>>>> These patches are not in mergable state, for the very least, they have >>>>> no information as to what they do, who wrote them, and all the other >>>>> meta-data we need to be able to read them. >>>> >>>> >>>> >>>> Hi Greg, >>>> >>>> Sorry for the late reply. The patch was obtained from these link: >>>> http://patchwork.ozlabs.org/patch/119923/ >>>> http://patchwork.ozlabs.org/patch/119924/ >>>> http://patchwork.ozlabs.org/patch/119925/ >>>> http://patchwork.ozlabs.org/patch/119925/ >>>> http://patchwork.ozlabs.org/patch/119926/ >>>> http://patchwork.ozlabs.org/patch/119927/ >>>> http://patchwork.ozlabs.org/patch/119928/ >>>> http://patchwork.ozlabs.org/patch/119929/ >>>> http://patchwork.ozlabs.org/patch/119930/ >>>> http://patchwork.ozlabs.org/patch/119931/ >>>> http://patchwork.ozlabs.org/patch/119932/ >>>> >>>> Are the meta-data in place? I'm still new to kernel patch, so please let me know >>>> if there's anymore things you need. Please advice on the work needed (as to >>>> rewrite, or to refactor). >>> >>> >>> >>> Before even proceeding to any formal requirements: have you checked how well it works with g_serial and g_ether? >>> >>> >>> Thank you. >>> Nikolai >> >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
