Re: [RFC 11/17] usb/ehci: make au1xxx use generic add code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Sebastian Andrzej Siewior a écrit :
> On Wed, Aug 31, 2011 at 11:26:13PM +0300, Felipe Balbi wrote:
>> Hi,
> Hi,
> 
> 
>>> - register offset (sometimes at 0x0 sometimes + 0x100). This however could be
>> struct resource ?
> 
> I though about this. It is not obvious to my why this has not been done in the
> first place. However it does look like there is something within the first
> 0x100 bytes thas is beeing used.
> 
Yes sometimes there is specific not-ehci register in the first 0x100 and there
are used to tune the hardware (what you can do with pci_(write|read)_config_byte
on pci ehci).

So they should be mapped somewhere where the init code can touch it.

I don't know how far you can share code between different platform ehci driver.
Most of stuff is already specific to hardware.

ehci_setup (http://marc.info/?l=linux-usb&m=130963323204872&w=2) was an attempt
to extract the common part.



Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux