Re: [PATCH 091/115] ehci-msm : use ehci_setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,


didn't you forgot the first part of the patch [1] ?
I don't see it in your patch list, and without this patch, msm driver won't
build (ehci_setup isn't defined).


Matthieu


[1]
http://marc.info/?l=linux-usb&m=130963323204872&w=2


Greg Kroah-Hartman a écrit :
> From: Matthieu CASTET <castet.matthieu@xxxxxxx>
> 
> Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxx>
> Tested-by: Pavankumar Kondeti <pkondeti@xxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> ---
>  drivers/usb/host/ehci-msm.c |   20 +-------------------
>  1 files changed, 1 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c
> index b5a0bf6..592d5f7 100644
> --- a/drivers/usb/host/ehci-msm.c
> +++ b/drivers/usb/host/ehci-msm.c
> @@ -40,27 +40,9 @@ static int ehci_msm_reset(struct usb_hcd *hcd)
>  	int retval;
>  
>  	ehci->caps = USB_CAPLENGTH;
> -	ehci->regs = USB_CAPLENGTH +
> -		HC_LENGTH(ehci, ehci_readl(ehci, &ehci->caps->hc_capbase));
> -	dbg_hcs_params(ehci, "reset");
> -	dbg_hcc_params(ehci, "reset");
> -
> -	/* cache the data to minimize the chip reads*/
> -	ehci->hcs_params = ehci_readl(ehci, &ehci->caps->hcs_params);
> -
>  	hcd->has_tt = 1;
> -	ehci->sbrn = HCD_USB2;
> -
> -	retval = ehci_halt(ehci);
> -	if (retval)
> -		return retval;
> -
> -	/* data structure init */
> -	retval = ehci_init(hcd);
> -	if (retval)
> -		return retval;
>  
> -	retval = ehci_reset(ehci);
> +	retval = ehci_setup(hcd);
>  	if (retval)
>  		return retval;
>  


-- 
Matthieu Castet
Ingénieur Développement Logiciel
Parrot SA
174 Quai de Jemmapes
75010 Paris, France

Tél: +33 (0) 1 48 03 74 78
Fax: +33 (0) 1 48 03 06 66
Email: matthieu.castet@xxxxxxxxx
http://www.parrot.biz
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux