Re: [RFC 11/17] usb/ehci: make au1xxx use generic add code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Aug 29, 2011 at 12:44:14PM +0200, Sebastian Andrzej Siewior wrote:
> On Mon, Aug 29, 2011 at 03:31:42PM +0530, ABRAHAM, KISHON VIJAY wrote:
> > > Is there a way that I can know this upfront? Like a flag somewhere or an
> > > assigned callback which isn't there otherwise?
> > 
> > maybe we can add a .irqflag member in hc_driver?
> 
> not int hc_driver. I want to have one struct which can be shared along all
> ehci drivers so extra fields which are unique to the platform / board in
> there are a no-no.
> If I get get many config arguments like this I may introduce a config struct
> which covers all of them.
> 
> What I see right now is
> - tt, big endian register and such
> - clocks

clock should be handled by ehci-<arch>.c. IOW, ehci-hcd should believe
clocks are on when it's starting. Also, if ehci-hcd.c should handle PM,
it should do so with pm_runtime APIs.

> - register offset (sometimes at 0x0 sometimes + 0x100). This however could be

struct resource ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux