Re: [RFC 11/17] usb/ehci: make au1xxx use generic add code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 31, 2011 at 11:26:13PM +0300, Felipe Balbi wrote:
> Hi,
Hi,

> > What I see right now is
> > - tt, big endian register and such
> > - clocks
> 
> clock should be handled by ehci-<arch>.c. IOW, ehci-hcd should believe
> clocks are on when it's starting. 
Yes, so this piece has to remain in ehci-arch.c file. Some architectures have
one clock, others have two. So I think that there there is no point in merging
them.

>Also, if ehci-hcd.c should handle PM,
> it should do so with pm_runtime APIs.

I think it does this already.

> > - register offset (sometimes at 0x0 sometimes + 0x100). This however could be
> 
> struct resource ?

I though about this. It is not obvious to my why this has not been done in the
first place. However it does look like there is something within the first
0x100 bytes thas is beeing used.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux