On Wed, Dec 22, 2010 at 10:49:42PM +0800, Ming Lei wrote:
Hi,
2010/12/22 Felipe Balbi <balbi@xxxxxx>:
it does. You can read all registers are 8-, 16- or 32- bit (except the
FIFOs), if I remember correctly.
Even readb can be implemented as readw() & 0xff, but writeb
is a little complicated, which may introduce extra overhead, such as
one extra read is needed to avoid destructing another byte.
it would only be used when we build am35x + omap2430 + tusb6010. So no
big deal there. That would be the only ifdef in that entire area.
It doesn't matter if bfin implements __raw_* macros or not since
tusb6010 is only used on ARM(maybe only OMAPs are involved).
It does, if all users of musb provide __raw_* we can drop all ifdefs and
use the static inline versions without any troubles. Then we don't need
to export symbols or anything to/from glue layer.
If readb and writeb on tusb6010 can be implemented as same with other
non-blackfin cases, exporting symbols of readb/writeb can be removed
since tusb6010 can't be used on blackfin ARCH, and we can keep the 'ifndef
BLACKFIN'.
the idea is to drop all of that and eventually get rid of the musb_io.h
header since it would be fairly small and could be integrated into
musb_core.h directly.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
