Re: [PATCH v1 12/27] usb: musb: same musb_readb/musb_writeb in single image to support multiple machines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

2010/12/22 Felipe Balbi <balbi@xxxxxx>:

> it does. You can read all registers are 8-, 16- or 32- bit (except the
> FIFOs), if I remember correctly.

Even readb can be implemented as readw() & 0xff, but writeb
is a little complicated, which may introduce extra overhead, such as
one extra read is needed to avoid destructing another byte.

>> It doesn't matter if bfin implements __raw_* macros or not since
>> tusb6010 is only used on ARM(maybe only OMAPs are involved).
>
> It does, if all users of musb provide __raw_* we can drop all ifdefs and
> use the static inline versions without any troubles. Then we don't need
> to export symbols or anything to/from glue layer.

If readb and writeb on tusb6010 can be implemented as same with other
non-blackfin cases, exporting symbols of readb/writeb can be removed
since tusb6010 can't be used on blackfin ARCH, and we can keep the 'ifndef
BLACKFIN'.

thanks,
-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux