On Wed, Dec 22, 2010 at 12:14:40AM +0800, tom.leiming@xxxxxxxxx wrote:
From: Ming Lei <tom.leiming@xxxxxxxxx> This patch introduces musb_readb/musb_writeb function pointer, so that we can use same musb_readb/musb_writeb in one single binary image to help to support multiple machines. Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
This I remember asking you to make a struct musb_io_ops to pass them and later asking for numbers of the overhead caused by a pointer deref which I think it's not a lot. Please measure the overhead caused by function pointers, if it's acceptable, I rather add those operations to some sort of struct musb_io_ops. I don't think there will be any difference, since you're already using function pointers anyway. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html