Hi,
2010/12/21 Felipe Balbi <balbi@xxxxxx>:
> Hi,
>
> On Tue, Dec 21, 2010 at 07:27:10PM +0800, Ming Lei wrote:
>>
>> OK, I will do a performance comparison between inline and function
>> pointers.
>
> The comparisson should be between your version and struct musb_io_ops
> version.
OK, I will do it.
>> The function pointer is only used to musb_readb/musb_writeb,
>> so not make struct musb_io_ops since I don't want musb_read{w,l}/
>> musb_write{w,l} involved in.
>
> To my eyes, it's much cleaner than exporting a function pointer symbol
> :-p
Yes, but we must make a leverage between cleanness and performance,
pointer deref may cause doubling or approaching to double the size of
this helpers since this kind of helpers may only have one or two
instructions, :-)
thanks,
--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
