Re: [PATCH v1 12/27] usb: musb: same musb_readb/musb_writeb in single image to support multiple machines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 22, 2010 at 10:03:00PM +0800, Ming Lei wrote:
You mean always accessing 16bit in musb_readb for all hw controllers?
I am not sure if musb can work well if so.

it does. You can read all registers are 8-, 16- or 32- bit (except the
FIFOs), if I remember correctly.

It doesn't matter if bfin implements __raw_* macros or not since
tusb6010 is only used on ARM(maybe only OMAPs are involved).

It does, if all users of musb provide __raw_* we can drop all ifdefs and
use the static inline versions without any troubles. Then we don't need
to export symbols or anything to/from glue layer.

Mike, would it be possible for blackfin to implement __raw_* macros so
we can drop the ifdef for blackfin on musb_io.h ??

The ifdef is used on different ARCH(bfin vs. other ARCHs), seems not
very important wrt. the issue, do it?

it does, see above.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux