On Wed, Jun 10, 2015 at 05:17:10PM +0700, Lars Melin wrote:
> On 2015-06-10 15:59, Joe wrote:
> > Lars Melin wrote:
> >
> >> If these hints to "Joe" justifies a Suggested-by then he can add me,
> >> info is in this mails header.
> >>
> >> I do however not agree to the place where "Joe" has stuck it into the
> >> usb_device_id list, it should not be among
> >> the other Olivetti entries but further down among numeric value vid:pid
> >> entries.
> >>
> >> /Lars
> > Thank you Lars for your answer! :)
> > Here we have an other hint, I could shift down my Olicard entry before submit the patch... no problem.
> > Here we are:
> >
> > -----------------------------------------------------------------------------------
> > --- linux/drivers/usb/serial/option.c.orig 2015-06-10 10:42:43.000000000 +0200
> > +++ linux/drivers/usb/serial/option.c 2015-06-10 10:53:06.825265579 +0200
> > @@ -1765,6 +1765,7 @@ static const struct usb_device_id option
> > { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) },
> > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */
> > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */
> > + { USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) }, /* OLICARD300 - MT6225 */
> > { USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
> > { USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) },
> > { } /* Terminating entry */
> > -----------------------------------
> >
> > What do you think about?
> > Could be a better placement?
> >
> > Let me know,
> > thanks again! :)
> >
>
> Yes that is a better place for it.
> I have added the usb serial maintainer as recipient since he is the one
> who has the final say.
Looks good to me. The general guideline is simply to keep related
entries together and to try to keep them sorted if possible (hard in
this case).
But why not use defines for the VID and PID (e.g. MEDIATEK_VENDOR_ID and
MEDIATEK_PRODUCT_MT6225) even if the device is sold under different
names? That way there would be more room to list any such aliases in a
comment section if needed.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
