Re: Patch Request of option.c module to support Olicard-300 (2020:4000)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2015-06-10 06:20, Peter Stuge wrote:
Joe wrote:
I'm considering the idea of posting without that tag for now,
so that you can evaluate/add my patch as soon as possible.
However... will it be possible, in case, to correct my previous
subbmitted patch to add the Suggested-by tag?
No, that's not possible. Once a commit has been included into the
repository that commit can not be changed.

I recommend to wait until you either get a response or get tired of waiting.
I haven't been giving much time to respond to the pm I received over in the usb_modeswitch forum but can confirm here that I have suggested "Joe" to

- submit a patch for the option driver to this list

- use the USB_DEVICE_INTERFACE_CLASS macro in order to avoid having to blacklist the net interfaces.

- not invent a false vendorname or assign a product name for the dongles entry in options usb_device_id list. The vid does most likely belong to MediaTek or one of its subsidiaries and is used for OEM products, the same vid:pid had already been seen for a differently named dongle (Rostelecom, Sense R41).

If these hints to "Joe" justifies a Suggested-by then he can add me, info is in this mails header.

I do however not agree to the place where "Joe" has stuck it into the usb_device_id list, it should not be among the other Olivetti entries but further down among numeric value vid:pid entries.

/Lars



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux