On Tue, Jun 09, 2015 at 01:14:30AM +0200, Joe wrote:
> Greg KH wrote:
>
> > On Fri, Jun 05, 2015 at 12:58:59AM +0200, Joe wrote:
> >>
> >> I've also created a patch as follows:
> >> -------------------------------------
> >> $ diff -up linux/drivers/usb/serial/option.c{.orig,} > \
> >> olivetti-olicard300-2020_4000.patch
> >>
> >> $ cat olivetti-olicard300-2020_4000.patch
> >> --- linux/drivers/usb/serial/option.c.orig 2015-06-05
> >> 00:27:28.000000000 +0200
> >> +++ linux/drivers/usb/serial/option.c 2015-06-05 00:37:08.522933592
> >> +0200 @@ -1678,6 +1678,7 @@ static const struct usb_device_id option
> >> .driver_info = (kernel_ulong_t)&net_intf6_blacklist },
> >> { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD500),
> >> .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
> >> + { USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) }, /*
> >> OLICARD300 - MT6225 */
> >> { USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650
> >> { CDMA
> >> 450 1xEVDO modem */
> >> { USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID,
> >> SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /* Samsung
> >> GT- B3730 LTE USB modem.*/
> >> { USB_DEVICE(YUGA_VENDOR_ID, YUGA_PRODUCT_CEM600) },
> >> -----------------------------------------------------------
> >>
> >> I'll attach it to this message, hope it is a good
> >> choice..
> >
> >
> > Can you resend this in the format described in
> > Documentation/SubmittingPatches so that we can be able to apply it to
> > the kernel tree?
> >
> > thanks,
> >
>
>
> First of all thanks to you!
>
> Well I created the above patch exactly following from that
> document, when it explain how to make a patch for a single
> file (Section 1, point 1):
>
> -------------------------------------------------------------------
> [...]
>
> To create a patch for a single file, it is often sufficient to do:
>
> SRCTREE= linux
> MYFILE= drivers/net/mydriver.c
>
> cd $SRCTREE
> cp $MYFILE $MYFILE.orig
> vi $MYFILE # make your change
> cd ..
> diff -up $SRCTREE/$MYFILE{.orig,} > /tmp/patch
> ----------------------------------------------------------
>
> What format do you mean exactly?
> Which part of that document are you exactly referring?
The sections about the signed-off-by line and the proper description and
subject lines :)
> Nice to contribute at kernel improvement and learn how to
> collaborate, anyway my "patch" just adds a single line to
> the source file of "option" module... so I also would be
> happy if you could re-create the patch for me.
Try it again so that you get proper credit for it.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
