Re: [BISECTED] - multiport braiboxes serial card broken between 4.8 and 4.9 (and again in 4.14)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi guys,

sorry for the delay, here are the files:

http://nik.lbox.cz/download/

lb7.01 is without the patch, lb7.02 is with it.

so far we've been using those boards (well, virtualy thousands
of them) with 4.4.52. I'm setting them up manually by script
which checks lspci output, gets parameters from there and
then uses setserial:

BRAINBOX_ID="135a:4100 (rev 02)"

$LSPCI 2>/dev/null | grep -q "${BRAINBOX_ID}" && {

    irq=`$LSPCI 2>/dev/null | grep "${BRAINBOX_ID}" -A6 | sed -n -e "s|.*IRQ \([[:digit:]]\+\).*|\1|p"`
    addr=`$LSPCI 2>/dev/null | grep "${BRAINBOX_ID}" -A6 | awk '/size=64/ {print $4}'|tr [:lower:] [:upper:]`
    ppaddr=0x`$LSPCI 2>/dev/null | grep "${BRAINBOX_ID}" -A7 | awk '/size=16/ {print $4}'|tr [:lower:] [:upper:]`

    addr2=$addr
    addr3=`echo "obase=16;ibase=16;$addr2+8" | bc`
    addr4=`echo "obase=16;ibase=16;$addr3+8" | bc`
    addr5=`echo "obase=16;ibase=16;$addr4+8" | bc`
    addr6=`echo "obase=16;ibase=16;$addr5+8" | bc`

    echo "Found BrainBoxes PX272/PX306 MIO card (ID 4100 rev 02)"
    echo "Setting up five serial ports: IRQ $irq, I/O at $addr2, $addr3, $addr4, $addr5, $addr6"
    /bin/setserial /dev/ttyS2  port 0x$addr2 irq $irq baud_base 921600 spd_normal skip_test autoconfig
    /bin/setserial /dev/ttyS3  port 0x$addr3 irq $irq baud_base 921600 spd_normal skip_test autoconfig
    /bin/setserial /dev/ttyS4  port 0x$addr4 irq $irq baud_base 921600 spd_normal skip_test autoconfig
    /bin/setserial /dev/ttyS5  port 0x$addr5 irq $irq baud_base 921600 spd_normal skip_test autoconfig
    /bin/setserial /dev/ttyS6  port 0x$addr6 irq $irq baud_base 921600 spd_normal skip_test autoconfig
}

with proposed patch, it now works for 4.14 as well..

br

nik


On Fri, Feb 02, 2018 at 03:43:41PM +0200, Andy Shevchenko wrote:
> On Thu, 2018-02-01 at 23:51 +0200, Andy Shevchenko wrote:
> > On Thu, 2018-02-01 at 22:31 +0200, Andy Shevchenko wrote:
> > > On Thu, 2018-02-01 at 20:28 +0100, Nikola Ciprich wrote:
> > > 
> > > 
> > > > 7d8905d064058f4b65057e0101588f362f288bc0 is the first bad commit
> > > > commit 7d8905d064058f4b65057e0101588f362f288bc0
> > > > Author: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > > Date:   Mon Jul 24 20:28:32 2017 +0300
> > > > 
> > > >     serial: 8250_pci: Enable device after we check black list
> > 
> > Looking to the patch more I have only one idea in mind. The driver now
> > skips the function 0 which seems has correct IRQ line and continues
> > with
> > the rest where it eventually matches devices as serial.
> > 
> > It would be nice to have output of
> > 
> > % lspci -vv -n -xxx # before _and_ after this commit applied (or
> > reverted)
> 
> Hmm... I'm not sure I understand fully what's going on there.
> Since there is no entry for the board it would fail either way (with or
> without above patch).
> 
> Can you send output of lspci as asked above and describe how your board
> works before?
> 
> (I think dmesg output with and without patch is also good to have, while
> kernel command line contains 'ignore_loglevel initcall_debug')
> 
> -- 
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Intel Finland Oy
> 

-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 00 Ostrava

tel.:   +420 591 166 214
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@xxxxxxxxxxx
-------------------------------------

Attachment: pgpWyUXJFVUq_.pgp
Description: PGP signature


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux