On 2018-01-31 08:20:00 [+0100], Nikola Ciprich wrote: > Hello Johan, Hi, > thanks for the reply. I tried 4.14.16-rc1 with the patch (it applies OK), > the system doesn't hang on port setup, but I'm still getting the backtraces > and the ports don't seem to work: > > [ 367.448414] WARNING: CPU: 1 PID: 1757 at lib/list_debug.c:31 __list_add_valid+0x4e/0x70 … > [ 367.448460] Call Trace: > [ 367.448464] univ8250_setup_irq+0x163/0x280 > [ 367.448468] serial8250_do_startup+0x1a5/0x780 > [ 367.448470] uart_startup.part.19+0x60/0x140 > [ 367.448471] uart_ioctl+0x9a5/0xa40 > [ 367.448474] tty_ioctl+0xea/0x8a0 > [ 367.448477] ? _copy_to_user+0x22/0x30 > [ 367.448480] ? cp_new_stat+0x150/0x180 > [ 367.448483] do_vfs_ioctl+0xa6/0x600 > [ 367.448486] ? __audit_syscall_entry+0xaf/0x100 > [ 367.448488] ? syscall_trace_enter+0x1cc/0x2b0 > [ 367.448490] SyS_ioctl+0x74/0x80 > [ 367.448492] do_syscall_64+0x61/0x1a0 > [ 367.448495] entry_SYSCALL64_slow_path+0x25/0x25 … > [ 367.450330] list_add double add: new=ffffffff829bbcc8, prev=ffffffff829bbcc8, next=ffffffff829bbcc8. > > I'll check what other patches have been submitted since 4.14.. > If you have some hint on more patches, it'll be welcome :) This looks like my crash before the patch. Does this hunk make a difference? diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 7e7e6eb95b0a..a15b5171c2ca 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1144,6 +1144,8 @@ static int uart_do_autoconfig(struct tty_struct *tty,struct uart_state *state) uport->ops->config_port(uport, flags); ret = uart_startup(tty, state, 1); + if (retval == 0) + tty_port_set_initialized(port, true); if (ret > 0) ret = 0; } > > cheers > > nik Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
