Re: [BISECTED] - multiport braiboxes serial card broken between 4.8 and 4.9

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sebastian,

yes, after some minor tweaking (retval -> ret) it builds and
traceback is gone! So it's a progress. 

However it seems that ports are behaving a bit strange, but
I'm only testing it the blunt way now, by cating file to /dev/ttySx
without anything attached (but on older kernels when the port was OK,
it was OK as well)

now the cat just hangs for long time, similar problem with setserial -g:

     0.000538 lstat("/dev", {st_mode=S_IFDIR|0755, st_size=3520, ...}) = 0
     0.000205 lstat("/dev/ttyS3", {st_mode=S_IFCHR|0660, st_rdev=makedev(4, 67), ...}) = 0
     0.000212 fstat(3, {st_mode=S_IFCHR|0660, st_rdev=makedev(4, 67), ...}) = 0
     0.000128 ioctl(3, TIOCGSERIAL, 0x7ffc0a9cfac0) = 0
     0.000111 write(1, "/dev/ttyS3, UART: 16750, Port: 0"..., 47/dev/ttyS3, UART: 16750, Port: 0xe088, IRQ: 11
) = 47
     0.000168 fstat(3, {st_mode=S_IFCHR|0660, st_rdev=makedev(4, 67), ...}) = 0
     0.000134 close(3)                  = 0
    30.206511 open("/dev/ttyS4", O_RDWR|O_NONBLOCK) = 3
     0.000479 lstat("/dev", {st_mode=S_IFDIR|0755, st_size=3520, ...}) = 0
     0.000192 lstat("/dev/ttyS4", {st_mode=S_IFCHR|0660, st_rdev=makedev(4, 68), ...}) = 0

the close(x) seems to always take 30s now.. ttyS0 is fine..

why could that be?

nik



> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 7e7e6eb95b0a..a15b5171c2ca 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1144,6 +1144,8 @@ static int uart_do_autoconfig(struct tty_struct *tty,struct uart_state *state)
>  		uport->ops->config_port(uport, flags);
>  
>  		ret = uart_startup(tty, state, 1);
> +		if (retval == 0)
> +			tty_port_set_initialized(port, true);
>  		if (ret > 0)
>  			ret = 0;
>  	}
> > 
> > cheers
> > 
> > nik
> 
> Sebastian
> 

-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 00 Ostrava

tel.:   +420 591 166 214
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@xxxxxxxxxxx
-------------------------------------

Attachment: pgpm5sIJuspDE.pgp
Description: PGP signature


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux