On 2018-01-31 12:26:50 [+0100], Nikola Ciprich wrote:
> Hi Sebastian,
Hi Nikola,
> yes, after some minor tweaking (retval -> ret) it builds and
> traceback is gone! So it's a progress.
oh, sorry for that.
Johan / Greg: do we want this fixed, too (like the previous one) or do
you have something else in mind?
> However it seems that ports are behaving a bit strange, but
> I'm only testing it the blunt way now, by cating file to /dev/ttySx
> without anything attached (but on older kernels when the port was OK,
> it was OK as well)
Not sure, I can't tell.
…
> the close(x) seems to always take 30s now.. ttyS0 is fine..
>
> why could that be?
it might want to wait until the FIFO is empty again. No clue. Do you see
interrupts coming? By setting the IRQ number to 0 (or using the patch
attached) it would use timer-base polling instead waiting for the
interrupt.
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -335,7 +335,7 @@ static int univ8250_setup_irq(struct uart_8250_port *up)
* hardware interrupt, we use a timer-based system. The original
* driver used to do this with IRQ0.
*/
- if (!port->irq) {
+ if (1) {
mod_timer(&up->timer, jiffies + uart_poll_timeout(port));
} else
retval = serial_link_irq_chain(up);
@@ -349,7 +349,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
del_timer_sync(&up->timer);
up->timer.function = serial8250_timeout;
- if (port->irq)
+ if (0)
serial_unlink_irq_chain(up);
}
> nik
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
