On Fri, 2018-02-02 at 09:51 +0100, Nikola Ciprich wrote: > yes, that did the trick! Good! > ports are still not autodetected, (but > it's no problem), but in lspci, the card has correct IRQ, and when > I set it using setserial, the same way I did in older kernels, it > seems to work! > > if it'll be pushed upstream, can you please add it to 4.14 stable as > well? Of course. > if you want me to test some more patches, I'm at your disposal, in > case it's not final fix. but now it looks OK (and pretty simple) to me Yes, I'll make an official patch later on, it would be nice to have your Tested-by tag on it. > thanks a lot for your help Thank you for pointing out to the real issue. > > > > 02:00.0 0702: 135a:4100 (rev 02) > > > > > > #define PCI_BASE_CLASS_COMMUNICATION 0x07 > > #define PCI_CLASS_COMMUNICATION_SERIAL 0x0700 > > #define PCI_CLASS_COMMUNICATION_PARALLEL 0x0701 > > #define PCI_CLASS_COMMUNICATION_MULTISERIAL 0x0702 > > #define PCI_CLASS_COMMUNICATION_MODEM 0x0703 > > #define PCI_CLASS_COMMUNICATION_OTHER 0x0780 > > > > And we check there only for 0x700 and 0x703. > > > > > > Can you try the following if it fixes the issue? > > > > --- a/drivers/tty/serial/8250/8250_pci.c > > +++ b/drivers/tty/serial/8250/8250_pci.c > > @@ -3392,6 +3392,7 @@ static int > > serial_pci_is_class_communication(struct pci_dev *dev) > > * later?) > > */ > > if ((((dev->class >> 8) != PCI_CLASS_COMMUNICATION_SERIAL) > > && > > + ((dev->class >> 8) != > > PCI_CLASS_COMMUNICATION_MULTISERIAL) > > && > > ((dev->class >> 8) != PCI_CLASS_COMMUNICATION_MODEM)) > > || > > (dev->class & 0xff) > 6) > > return -ENODEV; > > -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
