On 25/04/18 16:09, Tony Lindgren wrote: >> The commit you mention just dropped unused code. > > It was dropped because it was broken. Which meant nobody could > add any manual update displays without fixing it. And this is > how it became unused. Then Sebastian posted patches to fix it. Well, maybe this is semantics, but for me code that had never been used, had never worked, is not broken. It's unused code. You don't fix unused code, you implement the missing parts to get the feature enabled. >> I don't quite see the flag-day comparison. Manual update has never >> worked. It is essentially a new feature. Do we want to add a new feature >> right when we're doing a major restructuring, knowing that the new >> feature needs to be partly or even mostly rewritten during the >> restructuring? Or do we delay that new feature and implement it after >> the restructuring? > > But this is a flag day event :) You've been talking about this Ok, maybe I don't quite understand what flag-day event means, then. > magical event for years now and used it to block panels and > connectors. Yes, and I hate it. But the more omapdrm specific drivers we add, the more work we have moving to DRM model. And due to lack of resources, and the amount of work involved, it is taking much longer than I would hope. > And now I'm actually worried what other things will break this > time around. Clearly this change needs to be done in a way where > we can test every step for various features. Yes, exactly. And we are doing that, and that's taking a lot of time and resources. Which is why I'd rather not add even more features, to be gradually changed and tested every step, taking even more resources and time. >> I believe it will save everyone's time quite a bit if manual update is >> added after the restructuring. The downside is that we won't have this >> feature until after the restructuring is done. > > Let's not do that. That's exactly how we end up with losing > lots of the features again because of bugs because we can't > test things properly. Well, I feel this discussion is not going anywhere =). For you, manual update is a feature we support and need to keep working. For me, it's a new feature I want to add after the restructuring is done, as it'll cause problems during the restructuring. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
