Re: [PATCH] ARM: OMAP: n950: set display status to disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> > >>> Thanks applying into omap-for-v4.17/fixes.
> > >>
> > >> I don't think that's good idea.
> > >>
> > >> Hardware works just fine, its just that our drivers are broken. We
> > >> should _not_ modify dts. (But we could remove compatible from the
> > >> driver, or something...)
> > > 
> > > Hmm dropping compatible is not going to help with the generic
> > > "panel-dsi-mc" already in various dts files.
> > > 
> > > I guess you could add some check to the driver based on the
> > > of_machine_is_compatible().
> > > 
> > > Anyways dropping fix for now pending further discussion.
> > > Tomi, got any ideas?
> > 
> > How about disabling the DSI panel driver?
> > 
> > diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig
> > index a349cb61961e..a541d7937698 100644
> > --- a/drivers/gpu/drm/omapdrm/displays/Kconfig
> > +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig
> > @@ -41,7 +41,7 @@ config DRM_OMAP_PANEL_DPI
> >  
> >  config DRM_OMAP_PANEL_DSI_CM
> >         tristate "Generic DSI Command Mode Panel"
> > -       depends on BACKLIGHT_CLASS_DEVICE
> > +       depends on BACKLIGHT_CLASS_DEVICE && BROKEN
> >         help
> >           Driver for generic DSI command mode panels.
> 
> Works for me. Or let's just get the framedone interrupts
> working if that fixes it.

Both solutions work for me, but yes, getting framedone merged would be
really nice. Phones without displays are not too useful, and patches
were available for at least half a year now...

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux