Re: [PATCH] ARM: OMAP: n950: set display status to disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Tomi Valkeinen <tomi.valkeinen@xxxxxx> [180419 08:15]:
> 
> 
> On 19/04/18 00:09, Tony Lindgren wrote:
> > * Pavel Machek <pavel@xxxxxx> [180418 21:00]:
> >> On Wed 2018-04-18 12:21:39, Tony Lindgren wrote:
> >>> * Aaro Koskinen <aaro.koskinen@xxxxxx> [180418 11:37]:
> >>>> Display is not working on N950 yet, and having it enabled will cause
> >>>> issues with omapdrm during boot (long delays) and dmesg spam.
> >>>> Set it to disabled for time being.
> >>>>
> >>>> Fixes: 252130d8d6e0 ("ARM: dts: n950: add display support")
> >>>> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> >>>> Acked-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>
> >>>
> >>> Thanks applying into omap-for-v4.17/fixes.
> >>
> >> I don't think that's good idea.
> >>
> >> Hardware works just fine, its just that our drivers are broken. We
> >> should _not_ modify dts. (But we could remove compatible from the
> >> driver, or something...)
> > 
> > Hmm dropping compatible is not going to help with the generic
> > "panel-dsi-mc" already in various dts files.
> > 
> > I guess you could add some check to the driver based on the
> > of_machine_is_compatible().
> > 
> > Anyways dropping fix for now pending further discussion.
> > Tomi, got any ideas?
> 
> How about disabling the DSI panel driver?
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig
> index a349cb61961e..a541d7937698 100644
> --- a/drivers/gpu/drm/omapdrm/displays/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig
> @@ -41,7 +41,7 @@ config DRM_OMAP_PANEL_DPI
>  
>  config DRM_OMAP_PANEL_DSI_CM
>         tristate "Generic DSI Command Mode Panel"
> -       depends on BACKLIGHT_CLASS_DEVICE
> +       depends on BACKLIGHT_CLASS_DEVICE && BROKEN
>         help
>           Driver for generic DSI command mode panels.

Works for me. Or let's just get the framedone interrupts
working if that fixes it.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux