* Tomi Valkeinen <tomi.valkeinen@xxxxxx> [180424 07:10]: > On 23/04/18 19:03, Tony Lindgren wrote: > > > I guess I'm not fully clued into what all is missing. I was just > > thinking what I noticed we're missing weston a while back. See the > > test hack hack below, only compile tested. I have not played with > > weston at least for a year. But yeah I guess we still need dirtyfb > > support too and can't make omap_crtc_dss_start_update() do all the > > work for us? > > Yes, we need dirtyfb support too. I would think the dirtying mechanism > will call omap_crtc_dss_start_update(). OK, yes that does get called already AFAIK. > > /me thinks we're best of having the command mode displays working > > through all these changes though as then we can easily veirfy no > > regressions happen. I believe Sebastian already agreed to help > > with any changes needed few months ago. > > My point was that as we don't support manual update, there can be no > regressions. Well it seems the manual update support got removed with commit 5a35876e2830 ("drm: omapdrm: Remove manual update display support"). Reading the commit description I'd say the "interest in manual update displays" has been reality for close to a year now :) > With the current mainline code, if we so want, we can just rm > panel-dsi-cm and implement it and the related DSI code from scratch > using the DRM's panels. That's a lot easier than going from panel-dsi-cm > to DRM panels gradually, step by step, changing all the components in > the pipeline piece by piece and keeping things working after each commit. Eek, that sounds like a "flag day" plan: https://en.wikipedia.org/wiki/Flag_day_(computing) Trust me, we're better off keeping things working for every commit. It's good to have people using and testing the code. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html