On Thu, 22 Apr 2010 20:09:44 +1000 Nick Piggin <npiggin@xxxxxxx> wrote: > On Thu, Apr 22, 2010 at 04:25:36PM +0900, KAMEZAWA Hiroyuki wrote: > > On Thu, 22 Apr 2010 17:23:19 +1000 > > Nick Piggin <npiggin@xxxxxxx> wrote: > > > > > On Wed, Apr 21, 2010 at 12:17:58PM -0700, Andrew Morton wrote: > > > > > > > > fyi, I still consider these patches to be in the "stuck" state. So we > > > > need to get them unstuck. > > > > > > > > > > > > Hiroyuki (and anyone else): could you please summarise in the briefest > > > > way possible what your objections are to Daivd's oom-killer changes? > > > > > > > > I'll start: we don't change the kernel ABI. Ever. And when we _do_ > > > > change it we don't change it without warning. > > > > > > How is this turning into such a big issue? It is totally ridiculous. > > > It is not even a "cleanup". > > > > > > Just drop the ABI-changing patches, and I think the rest of them looked > > > OK, didn't they? > > > > > I agree with you. > > Oh actually what happened with the pagefault OOM / panic on oom thing? > We were talking around in circles about that too. > Hmm...checking again. Maybe related patches are: 1: oom-remove-special-handling-for-pagefault-ooms.patch 2: oom-default-to-killing-current-for-pagefault-ooms.patch IIUC, (1) doesn't make change. But (2)... Before(1) - pagefault-oom kills someone by out_of_memory(). After (1) - pagefault-oom calls out_of_memory() only when someone isn't being killed. So, this patch helps to avoid double-kill and I like this change. Before (2) At pagefault-out-of-memory - panic_on_oom==2, panic always. - panic_on_oom==1, panic when CONSITRAINT_NONE. After (2) At pagefault-put-of-memory, if there is no running OOM-Kill, current is killed always. In this case, panic_on_oom doesn't work. I think panic_on_oom==2 should work.. Hmm. why this behavior changes ? Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>