Re: [RFC] Input: wm97xx-core - Remove save state from wm97xx_read_aux_adc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 02, 2010 at 11:32:29AM -0400, Eric Millbrandt wrote:

> It does.  So I will modify wm97xx_read_aux_adc() to do the following:

> -Call poll_sample()
> -If the return value is not RC_VALID call poll_sample() again
> -If after 5 tries (I'm not sure how many samples can be queued) we have
> not succeeded, stop the digitizer and return -1.
> -Otherwise return auxadc.

> If this sounds reasonable I will create a patch for review.

Yup.  I'd return -EBUSY or something rather than a made up error code.
5 seems like a reasonable number of times to try.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux